Files
gems/opal-task/cmd/delete.go
T
joakim a68d701d14 Fix three critical UX issues in opal-task
Issue 1: Fix recurrence calculation for overdue tasks
- Use completion date (End) as base for next instance, not original due date
- If task due Monday completed Wednesday, next is Wednesday+7d not Monday+7d
- Fallback to Due date if End is not set
- Update test to verify new behavior

Issue 2: Fix description parsing to work without quotes
- Add parseAddArgs() to extract description from non-modifier words
- Description = all words that don't start with +, -, or contain :
- Enables: opal add buy groceries +shop carrots → 'buy groceries carrots'
- Validate description is required (error if only modifiers)
- Validate recurring tasks require due date

Issue 3: Implement flexible command syntax
- Add preprocessArgs() to parse arguments before Cobra routing
- Detect command position and split filters (left) from modifiers (right)
- Rewrite os.Args so Cobra routes correctly
- Enable both 'opal 2 done' and 'opal done 2' syntax
- Commands without modifiers accept filters on either side
- Commands with modifiers enforce [filters] command [modifiers]
- Add confirmation for modify without filters (modifies all tasks)

All commands updated to use preprocessed ParsedArgs from context.
All tests passing (33 tests).
2026-01-04 21:24:14 +01:00

53 lines
945 B
Go

package cmd
import (
"fmt"
"os"
"git.jnss.me/joakim/opal/internal/engine"
"github.com/spf13/cobra"
)
var deleteCmd = &cobra.Command{
Use: "delete [filter...]",
Short: "Delete tasks",
Run: func(cmd *cobra.Command, args []string) {
parsed := getParsedArgs(cmd)
if err := deleteTasks(parsed.Filters); err != nil {
fmt.Fprintf(os.Stderr, "Error: %v\n", err)
os.Exit(1)
}
},
}
func deleteTasks(args []string) error {
filter, err := engine.ParseFilter(args)
if err != nil {
return err
}
tasks, err := engine.GetTasks(filter)
if err != nil {
return err
}
if len(tasks) == 0 {
fmt.Println("No tasks matched.")
return nil
}
fmt.Printf("Delete %d task(s)? (y/N): ", len(tasks))
var confirm string
fmt.Scanln(&confirm)
if confirm != "y" && confirm != "Y" {
return nil
}
for _, task := range tasks {
task.Delete(false) // Soft delete
}
fmt.Printf("Deleted %d task(s).\n", len(tasks))
return nil
}