Files
gems/opal-task/internal/engine/ws_test.go
T
joakim 5b660c3c1c Fix working set IDs to match display order
BREAKING CHANGE: BuildWorkingSet() now accepts []*Task instead of *Filter

Problem:
- Working set IDs were assigned based on database query order (unsorted)
- Reports displayed tasks in sorted order (by urgency)
- Result: IDs didn't match displayed task positions (ID 1 wasn't first task)

Solution:
- Changed BuildWorkingSet() to accept pre-sorted task slice
- Reports now pass sorted tasks to BuildWorkingSet()
- IDs are assigned sequentially to match display order (1, 2, 3...)

Behavior:
- Reports rebuild working set on every execution with fresh IDs
- Task operations (done, modify, info) use saved working set IDs
- After completing a task, re-running report renumbers remaining tasks

Example:
  Before:  opal list shows ID 1 = low urgency task (wrong)
  After:   opal list shows ID 1 = highest urgency task (correct)

Tested scenarios:
✓ List report: IDs 1-N match urgency order
✓ Next report: IDs 1-5 match top urgent tasks
✓ Task completion: IDs renumber correctly after removal
✓ Multiple operations: Use saved working set (correct behavior)
✓ Different reports: Each builds own sequential IDs
2026-01-06 14:54:01 +01:00

166 lines
3.7 KiB
Go

package engine
import (
"testing"
)
func TestBuildWorkingSet(t *testing.T) {
// Create some tasks
task1, _ := CreateTask("Task 1")
task2, _ := CreateTask("Task 2")
task3, _ := CreateTask("Task 3")
// Get tasks and build working set
tasks, err := GetTasks(DefaultFilter())
if err != nil {
t.Fatalf("Failed to get tasks: %v", err)
}
ws, err := BuildWorkingSet(tasks)
if err != nil {
t.Fatalf("Failed to build working set: %v", err)
}
if ws.Size() < 3 {
t.Errorf("Expected at least 3 tasks in working set, got %d", ws.Size())
}
// Check that tasks are accessible by display ID
task, err := ws.GetTaskByDisplayID(1)
if err != nil {
t.Fatalf("Failed to get task by display ID: %v", err)
}
if task == nil {
t.Error("Task should not be nil")
}
// Verify tasks are in the set
_, exists := ws.byUUID[task1.UUID]
if !exists {
t.Error("Task 1 should be in working set")
}
_, exists = ws.byUUID[task2.UUID]
if !exists {
t.Error("Task 2 should be in working set")
}
_, exists = ws.byUUID[task3.UUID]
if !exists {
t.Error("Task 3 should be in working set")
}
}
func TestLoadWorkingSet(t *testing.T) {
// Create and build a working set
CreateTask("Load test 1")
CreateTask("Load test 2")
tasks, err := GetTasks(DefaultFilter())
if err != nil {
t.Fatalf("Failed to get tasks: %v", err)
}
ws1, err := BuildWorkingSet(tasks)
if err != nil {
t.Fatalf("Failed to build working set: %v", err)
}
size1 := ws1.Size()
// Load the working set
ws2, err := LoadWorkingSet()
if err != nil {
t.Fatalf("Failed to load working set: %v", err)
}
if ws2.Size() != size1 {
t.Errorf("Loaded working set size (%d) doesn't match built size (%d)", ws2.Size(), size1)
}
}
func TestWorkingSetWithFilter(t *testing.T) {
// Create tasks with different priorities
task1, _ := CreateTask("High priority task")
task1.Priority = PriorityHigh
task1.Save()
task2, _ := CreateTask("Low priority task")
task2.Priority = PriorityLow
task2.Save()
// Build working set with high priority filter
filter, _ := ParseFilter([]string{"priority:H"})
tasks, err := GetTasks(filter)
if err != nil {
t.Fatalf("Failed to get tasks: %v", err)
}
ws, err := BuildWorkingSet(tasks)
if err != nil {
t.Fatalf("Failed to build filtered working set: %v", err)
}
// Should only contain high priority task
_, exists := ws.byUUID[task1.UUID]
if !exists {
t.Error("High priority task should be in working set")
}
_, exists = ws.byUUID[task2.UUID]
if exists {
t.Error("Low priority task should NOT be in working set")
}
}
func TestGetTaskByDisplayID(t *testing.T) {
// Create tasks
CreateTask("Display ID test 1")
CreateTask("Display ID test 2")
CreateTask("Display ID test 3")
tasks, _ := GetTasks(DefaultFilter())
ws, _ := BuildWorkingSet(tasks)
// Test valid display IDs
for i := 1; i <= ws.Size(); i++ {
task, err := ws.GetTaskByDisplayID(i)
if err != nil {
t.Errorf("Failed to get task with display ID %d: %v", i, err)
}
if task == nil {
t.Errorf("Task with display ID %d should not be nil", i)
}
}
// Test invalid display ID
_, err := ws.GetTaskByDisplayID(999)
if err == nil {
t.Error("Should return error for invalid display ID")
}
}
func TestWorkingSetGetTasks(t *testing.T) {
// Create tasks
CreateTask("GetTasks test 1")
CreateTask("GetTasks test 2")
taskList, _ := GetTasks(DefaultFilter())
ws, _ := BuildWorkingSet(taskList)
tasks := ws.GetTasks()
if len(tasks) != ws.Size() {
t.Errorf("GetTasks returned %d tasks, expected %d", len(tasks), ws.Size())
}
// Verify tasks are in order
for i, task := range tasks {
displayID := i + 1
expectedUUID := ws.byID[displayID]
if task.UUID != expectedUUID {
t.Errorf("Task at position %d has wrong UUID", i)
}
}
}