From 4ef032cad60c9cec2c09b92a95f5d492daf34a22 Mon Sep 17 00:00:00 2001 From: Joakim Date: Sat, 20 Sep 2025 22:03:08 +0200 Subject: [PATCH] refactor: simplify CSS variables by removing 10 unused/redundant variables MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove 6 unused z-index variables (dropdown, sticky, fixed, popover) - Remove unused font-size-lg and bg-dark variables - Remove 4 overly-specific input variables, use existing spacing/color vars - Consolidate form styling to use core variables for consistency - Add internal CSS file to gitignore to prevent auto-generation conflicts - Reduces variable count from 38→28 (26% reduction) for easier maintenance --- .gitignore | 1 + lib/src/styles/insertr.css | 20 +++++--------------- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.gitignore b/.gitignore index 38ffaaa..1281ed0 100644 --- a/.gitignore +++ b/.gitignore @@ -91,6 +91,7 @@ demo-site/insertr.js demo-site/insertr.min.js internal/content/assets/insertr.js internal/content/assets/insertr.min.js +internal/content/assets/insertr.css # Test and build output directories test-output/ diff --git a/lib/src/styles/insertr.css b/lib/src/styles/insertr.css index 4feb49e..0b9a711 100644 --- a/lib/src/styles/insertr.css +++ b/lib/src/styles/insertr.css @@ -36,7 +36,6 @@ /* Background colors */ --insertr-bg-primary: #ffffff; --insertr-bg-secondary: #f8f9fa; - --insertr-bg-dark: #343a40; --insertr-bg-overlay: rgba(0, 0, 0, 0.5); /* Border and spacing */ @@ -48,12 +47,8 @@ --insertr-spacing-lg: 24px; /* Z-index management */ - --insertr-z-dropdown: 1000; - --insertr-z-sticky: 1020; - --insertr-z-fixed: 1030; --insertr-z-modal-backdrop: 1040; --insertr-z-modal: 1050; - --insertr-z-popover: 1060; --insertr-z-tooltip: 1070; --insertr-z-overlay: 999999; @@ -61,14 +56,9 @@ --insertr-font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, sans-serif; --insertr-font-size-sm: 12px; --insertr-font-size-base: 14px; - --insertr-font-size-lg: 16px; --insertr-line-height: 1.4; - /* Form elements */ - --insertr-input-padding: 0.75rem; - --insertr-input-border: 1px solid var(--insertr-border-color); - --insertr-input-border-focus: 1px solid var(--insertr-primary); - --insertr-input-bg: #ffffff; + /* Form elements - using existing variables */ /* Animation */ --insertr-transition: all 0.2s ease-in-out; @@ -435,14 +425,14 @@ body:not(.insertr-edit-mode) .insertr-editing-hover::after { .insertr-rich-editor, .insertr-fallback-textarea { width: 100%; - border: var(--insertr-input-border); + border: 1px solid var(--insertr-border-color); border-radius: var(--insertr-border-radius); - padding: var(--insertr-input-padding); + padding: var(--insertr-spacing-md); font-size: var(--insertr-font-size-base); line-height: var(--insertr-line-height); font-family: var(--insertr-font-family); color: var(--insertr-text-primary); - background: var(--insertr-input-bg); + background: var(--insertr-bg-primary); margin-bottom: var(--insertr-spacing-md); transition: var(--insertr-transition); box-sizing: border-box; @@ -452,7 +442,7 @@ body:not(.insertr-edit-mode) .insertr-editing-hover::after { .insertr-rich-editor:focus, .insertr-fallback-textarea:focus { outline: none; - border: var(--insertr-input-border-focus); + border: 1px solid var(--insertr-primary); box-shadow: 0 0 0 2px rgba(0, 123, 255, 0.25); }