joakim/gems
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use onMount return for cleanup instead of onDestroy

Browse Source 
onDestroy runs during SSR in Svelte 5, causing document reference
errors. The onMount return function only runs on client teardown.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Joakim
2026-02-19 16:35:18 +01:00
parent 4b35753fc7
commit 5301fbf706
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
opal-web/src/lib/components/BottomSheet.svelte
+5 -5
View File
@@ -1,5 +1,5 @@
<script> <script>
import { onMount, onDestroy, afterUpdate } from 'svelte'; import { onMount, afterUpdate } from 'svelte';
/** @type {boolean} */ /** @type {boolean} */
export let open = false; export let open = false;
@@ -72,11 +72,11 @@
onMount(() => { onMount(() => {
mounted = true; mounted = true;
document.addEventListener('keydown', handleKeydown); document.addEventListener('keydown', handleKeydown);
});
onDestroy(() => { return () => {
document.removeEventListener('keydown', handleKeydown); document.removeEventListener('keydown', handleKeydown);
document.documentElement.style.overflow = ''; document.documentElement.style.overflow = '';
};
}); });
/** /**